Release 0.4.4

This is the final iteration for DPS909. 

For part 4 of this iteration, as you may have noticed from my previous contributions. I like to participate with repo's related to math. 


This reposition that I found triangle-calculator is a tool that helps calculate certain values based on user input about a triangle. 

I think I caught the owner off-guard as he wasn't expecting for anyone to help with his issue. He was looking to get his tool tested. His code wasn't lacked functions/was not refactored so I couldn't really test his functions BUT I did manage to find bugs in his code. As he had asked me to create issues for him to fix those issues. I fixed minor issues for him and offered to help him with the bigger issues(if he was okay with me doing so). 

His code really showed me the importance of commenting/refactoring code as while I was going through his code understanding the logic was slightly tedious. 

I tried to use googles testing tool but gave up after a short while as I wasn't familiar with it at all. 

My PR can be found here : https://github.com/Kepler7894i/triangle-calculator/pull/13

Comments

Post a Comment

Popular posts from this blog

Improving Others Code !

Image
For this blog I was tasked to find a partner and improve some of their code. I decided to stick to Nathan's code as he used python to create his " PYLinkChecker ". The reasoning behind me as to why I choose his project is simply because as mentionned before I have never worked with python. This was an opportunity for me to learn a bit more about python and get out of my  coding comfort zone.  As I wasn't too familiar with python I also didn't want to overwhelm myself with adding some complicated feature. I previously noticed that his app was missing a bit of color so I took the liberty to make his program slightly more pleasing to the eyes.  As I wasn't working directly from the cmd line, I used GIT desktop to clone and pull his project.  As my changes were somewhat minor and didn't have much of an impact Nathan didn't give too many comments in regards to the changes, he was simply happy that I didn't forget to update his README file as my changes
Read more

Intro Blog

-            Why are you taking this course? I'm taking this course as I want to have some experience working with people that I don't know. With COVID-19 I know that working with people that you've never seen face to face is becoming more and more of a reality. I'm hoping that this course teaches me skills that I can later translate in my career. -             What is it about Open Source that attracted you? The ability to openly work on projects and know that it is a whole community of people that just want to improve things make Open Source interesting.  -             Where are you?  I was born in montreal and have a french background but live in Milton, Ontario ( Halton Region ). I moved closer to school when the campus transferred to Newnham but luckily moved back home right before COVID started.     -           What are you hoping to accomplish this term?  I'm looking to challenge myself & use this course to refresh myself with languages
Read more

Release 2.3

For this weeks pull request I decided to create my own issue in a project.  I found a data structure & algorithm repo that I could give some input into and also move away from html/javascript forms of coding. I chose this repo because data structures are very important to know as a programmer and some of the examples found in this repo could potentially be interview questions. I had created 2 issues for this repo, I wanted to add code so that one could see how to create a power function and a factorial function. The only difference was that I wanted to show both iteratively and recursively how to code those questions. Initially I had requested that both issues would be assigned to me (which was not an issue to me) but hours later after creating my issues I had some interest from other coders who wanted to add some of their code. Being in the spirit of hackoberfest I let one of the issues go and resolved 1 of the issues. This was interesting to me as I was not expecting for others t
Read more