First Code Review !

In this blog I talk about my first "open source" experience. I reviewed my classmates Nathan Pang's dead link checker coded in Python. 

I was luckily connected with him by my teacher as I had mistakenly confused the due dated for this first lab.

Testing this code was interesting because I have never  ran or written python code. It was a bit of a learning curb as I needed to do my own research on how to properly setup and run python on my own personal machine. Fortunately the syntax for Python is similar to many other languages so when reading the actual code it wasn't too bad to go through it. 

The thing that surprised me the most about working with another is how little things that you've overlooked can easily be spotted by another set of eyes. 


All 3 issues that I've created can be found below : 

https://github.com/NathanPang001/PYLinkChecker/issues/1

This first issue is in regards to HTML tags & unnecessary information being displayed only when pulling data from an HTML page.

https://github.com/NathanPang001/PYLinkChecker/issues/2

The second issue looks at how the improper error messages are displayed even an "Unknown" error message should be displayed

https://github.com/NathanPang001/PYLinkChecker/issues/3

The last issue is just a recommendation on the ReadME file to update & provide more sample information to properly display ALL potential cases when running this program. 


At this time the review on my side hasn't been completed yet so unfortunately I cannot provide links for my repo. 

Comments

Post a Comment

Popular posts from this blog

Improving Others Code !

Image
For this blog I was tasked to find a partner and improve some of their code. I decided to stick to Nathan's code as he used python to create his " PYLinkChecker ". The reasoning behind me as to why I choose his project is simply because as mentionned before I have never worked with python. This was an opportunity for me to learn a bit more about python and get out of my  coding comfort zone.  As I wasn't too familiar with python I also didn't want to overwhelm myself with adding some complicated feature. I previously noticed that his app was missing a bit of color so I took the liberty to make his program slightly more pleasing to the eyes.  As I wasn't working directly from the cmd line, I used GIT desktop to clone and pull his project.  As my changes were somewhat minor and didn't have much of an impact Nathan didn't give too many comments in regards to the changes, he was simply happy that I didn't forget to update his README file as my changes
Read more

Intro Blog

-            Why are you taking this course? I'm taking this course as I want to have some experience working with people that I don't know. With COVID-19 I know that working with people that you've never seen face to face is becoming more and more of a reality. I'm hoping that this course teaches me skills that I can later translate in my career. -             What is it about Open Source that attracted you? The ability to openly work on projects and know that it is a whole community of people that just want to improve things make Open Source interesting.  -             Where are you?  I was born in montreal and have a french background but live in Milton, Ontario ( Halton Region ). I moved closer to school when the campus transferred to Newnham but luckily moved back home right before COVID started.     -           What are you hoping to accomplish this term?  I'm looking to challenge myself & use this course to refresh myself with languages
Read more

Release 2.3

For this weeks pull request I decided to create my own issue in a project.  I found a data structure & algorithm repo that I could give some input into and also move away from html/javascript forms of coding. I chose this repo because data structures are very important to know as a programmer and some of the examples found in this repo could potentially be interview questions. I had created 2 issues for this repo, I wanted to add code so that one could see how to create a power function and a factorial function. The only difference was that I wanted to show both iteratively and recursively how to code those questions. Initially I had requested that both issues would be assigned to me (which was not an issue to me) but hours later after creating my issues I had some interest from other coders who wanted to add some of their code. Being in the spirit of hackoberfest I let one of the issues go and resolved 1 of the issues. This was interesting to me as I was not expecting for others t
Read more